Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] fix selection issue#14604

Merged
nturgut merged 1 commit into
flutter-team-archive:masterfrom
nturgut:selection_fix
Dec 23, 2019
Merged

[web] fix selection issue#14604
nturgut merged 1 commit into
flutter-team-archive:masterfrom
nturgut:selection_fix

Conversation

@nturgut

@nturgut nturgut commented Dec 21, 2019

Copy link
Copy Markdown
Contributor

The mouse selection by the browser was colliding with the selection synced from flutter which was creating a flickering.

the PR is preventing default for mouse up, down, move which fixes the issue. Fix does not change IOS and Android strategies.

Tested on: Chrome on linux, Firefox on Linux.

fixes: flutter/flutter#45848

@nturgut
nturgut requested a review from mdebbar December 21, 2019 00:07
@auto-assign
auto-assign Bot requested a review from liyuqian December 21, 2019 00:07
@nturgut
nturgut removed the request for review from liyuqian December 21, 2019 00:08
mdebbar
mdebbar approved these changes Dec 23, 2019
View reviewed changes

@mdebbar mdebbar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix!

@nturgut
nturgut merged commit c2f44be into flutter-team-archive:master Dec 23, 2019
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 26, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 26, 2019
@engine-flutter-autoroll
c2f44be fix selection issue (flutter-team-archive/engine#14604)
8a1fba8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 26, 2019
@engine-flutter-autoroll
c2f44be fix selection issue (flutter-team-archive/engine#14604)
b2a5373
This was referenced Dec 26, 2019
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 26, 2019
@engine-flutter-autoroll
c2f44be fix selection issue (flutter-team-archive/engine#14604)
9d76a57
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Dec 26, 2019
@engine-flutter-autoroll
Roll engine 42bb7c9..dc0187f (15 commits) (#47829)
149e31c 
flutter-team-archive/engine@42bb7c9...dc0187f

git log 42bb7c9..dc0187f --first-parent --oneline
2019-12-24 skia-flutter-autoroll@skia.org Roll src/third_party/dart 8736fec094bb..75fc15c7e186 (6 commits) (flutter-team-archive/engine#14679)
2019-12-24 liyuqian@google.com Run and collect benchmarks (flutter-team-archive/engine#14556)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4a639e8df261..8736fec094bb (11 commits) (flutter-team-archive/engine#14678)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia ac29f1342fd2..a2d7225c0fc1 (5 commits) (flutter-team-archive/engine#14677)
2019-12-23 nurhan@google.com fix selection issue (flutter-team-archive/engine#14604)
2019-12-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from TUoVa... to v3R8A... (flutter-team-archive/engine#14670)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart cfca5ea9f2e9..4a639e8df261 (7 commits) (flutter-team-archive/engine#14671)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6ec826085b2a..ac29f1342fd2 (1 commits) (flutter-team-archive/engine#14672)
2019-12-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from IZ278... to ZA31z... (flutter-team-archive/engine#14675)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/dart 1db1a837f8c9..cfca5ea9f2e9 (2 commits) (flutter-team-archive/engine#14667)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2723af6a6d43..6ec826085b2a (3 commits) (flutter-team-archive/engine#14665)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/dart c260e4e8dac6..1db1a837f8c9 (8 commits) (flutter-team-archive/engine#14606)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia 28b0c5d4b3bb..2723af6a6d43 (4 commits) (flutter-team-archive/engine#14605)
2019-12-20 dnfield@google.com View ref pair (flutter-team-archive/engine#14602)
2019-12-20 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from VC7eE... to IZ278... (flutter-team-archive/engine#14603)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 28, 2019
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 28, 2019
@engine-flutter-autoroll
c2f44be fix selection issue (flutter-team-archive/engine#14604)
2f62834
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Dec 28, 2019
@engine-flutter-autoroll
Roll engine 5a730c6..bdc9708 (25 commits) (#47926)
841924e 
flutter-team-archive/engine@5a730c6...bdc9708

git log 5a730c6..bdc9708 --first-parent --oneline
2019-12-28 franciscojma86@gmail.com Revert "Use ELF for Dart AOT snapshots on Fuchsia. (#13896)" (flutter-team-archive/engine#14823)
2019-12-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia 89bf1547f3aa..5a2f962313a5 (16 commits) (flutter-team-archive/engine#14825)
2019-12-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from ikxBh... to sxapd... (flutter-team-archive/engine#14821)
2019-12-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from IEPKx... to iImpF... (flutter-team-archive/engine#14817)
2019-12-27 skia-flutter-autoroll@skia.org Roll src/third_party/dart 94a4f6415e6c..c547f5d933e5 (9 commits) (flutter-team-archive/engine#14812)
2019-12-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia f2d522a3f434..89bf1547f3aa (4 commits) (flutter-team-archive/engine#14814)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/dart 232a171a0b1c..94a4f6415e6c (8 commits) (flutter-team-archive/engine#14808)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 07d744fb8a53..f2d522a3f434 (4 commits) (flutter-team-archive/engine#14807)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 05eb83be171c..07d744fb8a53 (3 commits) (flutter-team-archive/engine#14806)
2019-12-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v3R8A... to ikxBh... (flutter-team-archive/engine#14802)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/dart 75fc15c7e186..232a171a0b1c (4 commits) (flutter-team-archive/engine#14803)
2019-12-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from ZA31z... to IEPKx... (flutter-team-archive/engine#14702)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3d3150c89c5f..05eb83be171c (3 commits) (flutter-team-archive/engine#14800)
2019-12-24 skia-flutter-autoroll@skia.org Roll src/third_party/skia a2d7225c0fc1..3d3150c89c5f (1 commits) (flutter-team-archive/engine#14680)
2019-12-24 skia-flutter-autoroll@skia.org Roll src/third_party/dart 8736fec094bb..75fc15c7e186 (6 commits) (flutter-team-archive/engine#14679)
2019-12-24 liyuqian@google.com Run and collect benchmarks (flutter-team-archive/engine#14556)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4a639e8df261..8736fec094bb (11 commits) (flutter-team-archive/engine#14678)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia ac29f1342fd2..a2d7225c0fc1 (5 commits) (flutter-team-archive/engine#14677)
2019-12-23 nurhan@google.com fix selection issue (flutter-team-archive/engine#14604)
2019-12-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from TUoVa... to v3R8A... (flutter-team-archive/engine#14670)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart cfca5ea9f2e9..4a639e8df261 (7 commits) (flutter-team-archive/engine#14671)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6ec826085b2a..ac29f1342fd2 (1 commits) (flutter-team-archive/engine#14672)
2019-12-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from IZ278... to ZA31z... (flutter-team-archive/engine#14675)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/dart 1db1a837f8c9..cfca5ea9f2e9 (2 commits) (flutter-team-archive/engine#14667)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2723af6a6d43..6ec826085b2a (3 commits) (flutter-team-archive/engine#14665)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@jlcool

jlcool commented Feb 4, 2020

Copy link
Copy Markdown

The problem is still there. How can I make sure he's fixed

[√] Flutter (Channel master, v1.14.7-pre.98, on Microsoft Windows [Version 10.0.18362.592], locale zh-CN)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Professional 2019 16.4.2)
[√] Android Studio (version 3.4)
[√] Connected device (3 available)

• No issues found!

filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
@filmil
fix selection issue (flutter-team-archive#14604)
1785dda
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mdebbar mdebbar mdebbar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web] Erratic text selection behavior

4 participants

@nturgut @jlcool @mdebbar @googlebot